Rebrand Omniperf to ROCm Compute Profiler to ROCm 6.3 branch #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check that the minimum required Python (3.8) version is used. Prints a descriptive error message, rather than a cryptic import failure, if minimum Python version is not met. Internal ticket SWDEV-477233. * Disable the RPM mangling of shebangs. The are changing the `#!/usr/bin/python3` to `#!/usr/libexec/platform-python`. With this set, omniperf is always using the platform installed version of python, which is python 3.6 on RHEL 8. Using virtual environments, like conda, did not work. * Fix pylint issues --------- Signed-off-by: David Galiffi <[email protected]>
* Remove `dev` and `main` branch from workflows. Update links in documentation. Signed-off-by: David Galiffi <[email protected]> * `amd-staging` -> `amd-mainline` in docs Signed-off-by: Peter Jun Park <[email protected]> --------- Signed-off-by: David Galiffi <[email protected]> Signed-off-by: Peter Jun Park <[email protected]> Co-authored-by: Peter Jun Park <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: Peter Jun Park <[email protected]>
If we don't add the suffix omniperf to the install path then the subsequent instruction of module load omniperf will not work Signed-off-by: coleramos425 <[email protected]>
…ular plugin (#416) Signed-off-by: coleramos425 <[email protected]>
After meeting with the DevOps team, I've added the Unreleased keyword to new CHANGELOG section per their request Signed-off-by: coleramos425 <[email protected]>
Signed-off-by: Peter Jun Park <[email protected]>
Signed-off-by: Daniel Su <[email protected]>
* Add the ability to determine GPU model from Chip ID for distinguishing MI300 systems by using a built-in dictionary. Signed-off-by: xuchen-amd <[email protected]> * Add support for MI300X_A1 Signed-off-by: xuchen-amd <[email protected]> * Remove MI308X identification using num CUs, and format Python using black. Signed-off-by: xuchen-amd <[email protected]> * Add Read the Docs Signed-off-by: xuchen-amd <[email protected]> * Add sphinx requirement Signed-off-by: xuchen-amd <[email protected]> * Remove gpu_model identification using gpu_arch Signed-off-by: xuchen-amd <[email protected]> * Remove OMNIPERF_ARCH_OVERRIDE and its usage. Determining MI300 gpu model solely based on chip id. Signed-off-by: xuchen-amd <[email protected]> * Fix Python formatting using black. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
* Package release tarball on rocm tags and add a MAINTAINERS guide to outline release procedure Signed-off-by: coleramos425 <[email protected]> * Apply linting feedback Signed-off-by: coleramos425 <[email protected]> * Update links in MAINTAINERS for new branches Signed-off-by: coleramos425 <[email protected]> * Update MAINTAINERS.md for changelog formatting Signed-off-by: coleramos425 <[email protected]> * Update Omniperf ver checker to allow tags with rocm- prefix Signed-off-by: coleramos425 <[email protected]> * Add step to packaging workflow to upload release tarball to release Signed-off-by: coleramos425 <[email protected]> * Synax change for release name in packaging action Signed-off-by: coleramos425 <[email protected]> * Update MAINTAINERS for instuctions on ROCm releases Signed-off-by: coleramos425 <[email protected]> * Update softprops pluvin to v2 and remove release name Removing the release name enables us to modify an existing release with the matching tag Signed-off-by: coleramos425 <[email protected]> * Remove draft option on softprops plugin Signed-off-by: coleramos425 <[email protected]> --------- Signed-off-by: coleramos425 <[email protected]>
Signed-off-by: Carrie Fallows <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
* Avoid crash if non-UTF8 character is encountered in output Signed-off-by: benrichard-amd <[email protected]> * Ignore lines with non-UTF-8 characters. Do not print error. Signed-off-by: benrichard-amd <[email protected]> * Remove trailing whitespace Signed-off-by: benrichard-amd <[email protected]> --------- Signed-off-by: benrichard-amd <[email protected]>
…network proxy services (#440) * Documented Docker container OpenSSL abilities being affected by host network proxy services, causing network certificates verification problem during Docker container build stage of Grafana server setup. Signed-off-by: Vladimir Stempen <[email protected]> * Update docs/install/grafana-setup.rst Co-authored-by: Peter Park <[email protected]> Signed-off-by: vstempen <[email protected]> --------- Signed-off-by: Vladimir Stempen <[email protected]> Signed-off-by: vstempen <[email protected]> Co-authored-by: Peter Park <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
In a previous change we started using "MI300" for gpu_model instead of the full "MI300X_A0" or "MI300X_A1", etc. The XCD detection code was using gpu_model and expecting the full name, causing the XCD count = 1. Passing chip_id fixes the issue. Signed-off-by: benrichard-amd <[email protected]>
…tats'. (#449) Signed-off-by: OReilly, Ossian <[email protected]>
* Enable baseline comparison between workloads from the same path Signed-off-by: zichguan-amd <[email protected]> * Formatting Signed-off-by: zichguan-amd <[email protected]> * Change test to verify baseline works with same path Signed-off-by: zichguan-amd <[email protected]> * Add three-way comparison test case Signed-off-by: zichguan-amd <[email protected]> --------- Signed-off-by: zichguan-amd <[email protected]>
* Check for missing mclk, use hard-coded values if needed Signed-off-by: benrichard-amd <[email protected]> * Fix typo Signed-off-by: benrichard-amd <[email protected]> --------- Signed-off-by: benrichard-amd <[email protected]>
- Update filenames. - Update executable to `rocprof-compute` - Update update package to `rocprofiler-compute` - Update name in application output and logs - Update name in README files - Update testing and workflows --------- Signed-off-by: Xuan Chen <[email protected]>
Signed-off-by: coleramos425 <[email protected]>
* Update VERSION and README to 3.0.0 * Update version mismatch of profiling data to a warning. Signed-off-by: David Galiffi <[email protected]>
* Install LICENSE to ${CMAKE_INSTALL_DOCDIR}
* Update tarball.yml to test for LICENSE file after the install
---------
Signed-off-by: David Galiffi <[email protected]>
Signed-off-by: fei.zheng <[email protected]>
Signed-off-by: Peter Park <[email protected]>
Fix PoP of VALU Active Threads with wave_size
dgaliffiAMD
requested review from
a team,
koomie and
coleramos425
as code owners
dgaliffiAMD
changed the title
* find/replace Omniperf to ROCm Compute Profiler Signed-off-by: Peter Park <[email protected]> * update name in Sphinx conf Signed-off-by: Peter Park <[email protected]> * mv what-is-omniperf.rst -> what-is-rocprof-compute.rst Signed-off-by: Peter Park <[email protected]> * update Tutorials section Signed-off-by: Peter Park <[email protected]> * add Omniperf as keyword to Conceptual section for internal search Signed-off-by: Peter Park <[email protected]> * update Reference section Signed-off-by: Peter Park <[email protected]> * black fmt conf.py Signed-off-by: Peter Park <[email protected]> * update profile mode and basic usage subsections Signed-off-by: Peter Park <[email protected]> * update how to use analyze mode subsection Signed-off-by: Peter Park <[email protected]> * update install section Signed-off-by: Peter Park <[email protected]> * fix sphinx warnings Signed-off-by: Peter Park <[email protected]> * fix cmd line examples in profile/mode.rst Signed-off-by: Peter Park <[email protected]> * update install decision tree image Signed-off-by: Peter Park <[email protected]> * fix TOC and index Signed-off-by: Peter Park <[email protected]> fix weird wording * fix cli text: deriving rocprofiler-compute metrics... Signed-off-by: Peter Park <[email protected]> * update standalone-gui.rst Signed-off-by: Peter Park <[email protected]> * restore removed doc updates from #428 Signed-off-by: Peter Park <[email protected]> * update ref to Omniperf in index.rst Signed-off-by: Peter Park <[email protected]> * fix grafana connection name to match image Signed-off-by: Peter Park <[email protected]> * update cmds in tutorials Signed-off-by: Peter Park <[email protected]> --------- Signed-off-by: Peter Park <[email protected]>
* Update name and icon for browser tab to rocprofiler-compute. Signed-off-by: xuchen-amd <[email protected]> * Update name and icon for browser tab to rocprofiler-compute. Signed-off-by: xuchen-amd <[email protected]> --------- Signed-off-by: xuchen-amd <[email protected]>
This was referenced Nov 6, 2024
Merged
Signed-off-by: David Galiffi <[email protected]>
feizheng10
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge changes from mainline to release/rocm-rel-6.3